reasonml / reasonml/reason

Revert #1460

Open
#1,461 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

GOOD FIRST TASK
Dominant language
OCaml
Stars
10.3k
Forks
438
PR merge metrics
No merged PRs in 30d

Description

See the comment on that PR. It's a workaround to make the unit tests more relevant, because it was previously failing all the time due to some doc block formatting problem & ocaml 4.02 problem.

After we ship the new syntax, revert that PR, make the tests fail again, and fix them.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read issue #1460 and its pull request comment, then inspect the unit tests affected by the doc block formatting problem and OCaml 4.02. After the new syntax ships, revert #1460, confirm the tests fail again, and fix the underlying test issues.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
18/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.