Allow data-* in DOM elements

Open
#230 16 comments 11 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
react
Domain
frontend

Research direction

Start by locating the existing ariaFoo handling in the React DOM element bindings and reviewing how cloneElement could serve as the proposed escape hatch. Done means DOM elements can accept dynamic data-* attributes through the supported approach, with coverage confirming that behavior.

Written by the indexing model from the issue text.

Description

enhancement help wanted

aria-foo is supported through ariaFoo, because we exhaustively list all the aria options. data-* is dynamic. I think it's fine to use cloneElement to add them as an escape hatch.

Dominant language
Reason
Stars
3.3k
Forks
344
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reasonml/reason-react

All issues in reasonml/reason-react

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.