Infinite loop if Windows drive letters don't match
Open
Nobody has claimed this yet.
bug
resolved
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
I'm using swiftlint in a checkout on my Windows D: drive. If I run swiftlint with a config file on a different drive, like --config C:\temp\foo it infinite loops trying to find the shortest common substring of the paths.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by running SwiftLint from a checkout on one Windows drive with --config pointing to another, such as D: and C:\temp\foo. Inspect the path-handling logic that searches for the shortest common substring; done means the command terminates instead of looping when the drive letters differ.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100