`control_statement` kills inline comments
Open
Nobody has claimed this yet.
bug
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- I've Updated SwiftLint to the latest version.
- I've searched for existing GitHub issues.
Bug Description
control_statement kills inline comments
Code before:
if (abc == 1/* && cdf == 2*/) {
print("Hello, world!")
}
Run SwiftLint
swiftlint --fix
Code afterwards:
if abc == 1 {
print("Hello, world!")
}
I would prefer it to keep comments and thus be:
if abc == 1/* && cdf == 2*/ {
print("Hello, world!")
}
See repo here: https://github.com/herrernst/swiftlint-control_statement-comments
Environment
- SwiftLint version (run
swiftlint versionto be sure): 0.59.1 - Xcode version (run
xcodebuild -versionto be sure): Xcode 16.4 (Build version 16F6) - Installation method used (Homebrew, CocoaPods, building from source, etc): SPM
- Configuration file: none (default configuration)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the provided C-style snippet and swiftlint --fix, then trace the control_statement autocorrection behavior. The fix is complete when the inline comment remains in place after autocorrection, with regression coverage for the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100