Rule suggestion: guard let instead of huge if let
Open
Nobody has claimed this yet.
rule-request
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
Instead of something like:
if let aVariable = something,
anotherVariable = somethingElse {
// A
// huge
// indented
// body
// of
// code
}
I think it's generally better to do something like:
guard let aVariable = something,
anotherVariable = somethingElse else { return }
// A
// huge
// unindented
// body
// of
// code
There could be a limit to the number of lines inside the if let to trigger the rule.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by locating SwiftLint's rule implementation and existing tests for if-let syntax; define done as a rule that detects the proposed guard-let case and applies any agreed line-count threshold.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100