Rule Request: [empty_catch]
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
New rule request
Please describe the rule idea, format
this issue's title as Rule Request: [Rule Name] and describe:
- Why should this rule be added? Share links to existing discussion about what
the community thinks about this.
I think we should have a rule that triggers when someone writes a do-catch, and leaves the catch empty. Cases like this should just use try?
- Provide several examples of what would and wouldn't trigger violations.
Bad
do {
try doStuff()
} catch {
}
Good
do {
try doStuff()
} catch {
Logger().error("\(error.localizedDescription)")
}
- Should the rule be configurable, if so what parameters should be configurable?
no configuration needed
- Should the rule be opt-in or enabled by default? Why?
See README.md for guidelines on when to mark a rule as opt-in.
I think this should be enabled by default, although I can understand the amount of noise that might cause for existing projects.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the opt-in-rule guidance in README.md and the issue's bad and good Swift examples. Review how existing SwiftLint rules and their tests are organized, then confirm the rule's behavior for empty versus non-empty catch blocks and whether it is enabled by default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100