Questionable Accessibility Advice

New Issue Checklist

A fellow friend of mine passionate about iOS Accessibility shared this issue description with me.

https://github.com/realm/SwiftLint/blob/ff1e966e3ae8ef9876ec5e80c060a46b5faae8f4/Source/SwiftLintBuiltInRules/Rules/Lint/AccessibilityTraitForButtonRule.swift

I love the idea of a Linting library for Accessibility. I actually built one attached to LLVM for Deque back like 10 years ago attached to CLANG for Objective C analysis... The logic I found analyzing UIView ASTSs back then applies to Swift the same. This rule needs some help :).

The description for this issues suggests that every tappable iOS Control should be Button or a Link. This shows a misunderstanding of what these traits do and their relationship to the Rotor. Counterexamples to this rule include:

• Interactive GridView Items - Like the iOS launcher screen.
• Switches, checkboxes, etc.
• Interactive selectable ListViewCells

Note: There are more counter examples than examples.

A rule that would more accurately satisfy the documented intent of this rule would be a rule that made sure controls that were attempting to exhibit single tap behavior did so utilizing gestures that Voice Control and Switch Control recognize as having a default action... being clickable.

Or even a rule that recommended removing the Trait of Button or Link from a control with a changing value... "Switch Button" should never happen.

Let's chat! :) https://www.linkedin.com/in/ciaiguy/

Start with Source/SwiftLintBuiltInRules/Rules/Lint/AccessibilityTraitForButtonRule.swift and compare its documented intent with the listed iOS control counterexamples. Done requires an agreed correction to the rule's accessibility guidance and a maintainer-approved implementation scope; the issue does not name a test or exact replacement behavior.