realm / realm/SwiftLint

Duplicate Key in Dictionary Literal with Computed Var

Open
#5,077 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acceptable-false-positive bug
Dominant language
Swift
Stars
19.7k
Forks
2.3k
Avg merge
1d 1h
Merged PRs (30d)
11

Description

New Issue Checklist
Describe the bug

The duplicated_key_in_dictionary_literal warning is triggered when one static computed var is used repeatedly in a dictionary literal, despite the var being computed and therefore not necessarily the same on every read.

Complete output when running SwiftLint, including the stack trace and command used
$ swiftlint lint
warning: Duplicated Key in Dictionary Literal Violation: Dictionary literals with duplicated keys will crash at runtime (duplicated_key_in_dictionary_literal)
Environment
  • SwiftLint version: 0.52.3
  • Installation method used: Homebrew
  • Paste your configuration file: N/A (default config)
// This triggers a violation:
var currentValue = 0
var generateNewValue: Int {
    let current = currentValue
    currentValue += 1
    return current
}

let testDict = [
    generateNewValue: "",
    generateNewValue: "",
    generateNewValue: "",
]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the warning with the Swift code in the issue using swiftlint lint, focusing on the duplicated_key_in_dictionary_literal rule. Trace that rule's handling of repeated computed properties and add coverage showing that successive computed reads can produce distinct keys; done means the example no longer receives an incorrect warning while genuinely duplicated keys remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.