Rule Request: `redundant_self_in_non_escaping_closure`
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New rule request
The existing rule redundant_self_in_closure is unable to know whether a closure capturing self in a class is actually not @escaping. An Analyzer rule would know the type of the closure at hand. The rule should flag usages of self in closures that are not @escaping in classes.
See the original rule request #59 and its (partial) implementation #4911 for more details. The herein requested rule complements redundant_self_in_closure and may inherit/use parts of its implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing redundant_self_in_closure rule and the partial implementation in pull request #4911, then compare them with the original request in issue #59. The work is complete when an Analyzer rule flags self usages in non-escaping closures within classes while complementing the existing rule.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100