`opening_brace` on separate line should be permissible
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
Describe the bug
opening_brace does not permit the brace to open on a separate line. However, this restriction can be excessive.
Some examples of cases where it might be very reasonable to open a block on its own line:
When a block takes another block as a return value:
destination: self.model.member.flatMap { member in
{ self.presenter?.detailsPresenter(for: member).view }
}
When a block is an option in a ternary:
destination: !slot.screens.isEmpty ?
{ self.router.screenshots(for: slot.screens, metrics: segment.metrics).featurePresenter } :
{ self.router.members(with: self.members.eraseToAnyChoice()).featurePresenter }
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the opening_brace rule but no source file or test. Start by locating that rule and its existing tests, then compare the behavior with the two Swift examples; done means the intended separate-line closures are accepted while existing brace checks remain covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100