realm / realm/SwiftLint

Rule Request: redundant_optional_initialization as default may cause extra work with Swift 6

Open
#4,010 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

rule-request
Dominant language
Swift
Stars
19.7k
Forks
2.3k
Avg merge
1d 1h
Merged PRs (30d)
11

Description

New Issue Checklist
New rule request

In anticipation of possible requirements to initialise all optionals explicitly, I declared a private var dataSource: UICollectionViewDataSource? = nil and ran into the redundant_optional_initialization rule. As #2785 requests, there should be an »inverted« version of that rule for those who want to minimise for possible Swift 6 migration issues.

But by having the rule enabled by default, many more users may be facing more busywork if and when Swift 6 arrives with changed rules regarding Optional initialisation, at which point the rule will have to be removed in any case for Swift 6 mode. It therefore makes sense to disable the redundant_optional_initialization by default until it can be expected that the rule will not run afoul of the language's own rules in the near future.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the redundant_optional_initialization rule and SwiftLint's default-rule configuration. Review how default-enabled rules are tested, then determine the expected default behavior and update the relevant tests so completion can be verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.