Rule Request: Configuration `onlyEnforceBeforeTrivialLines` for `VerticalWhitespaceClosingBracesRule`
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
Vertical whitespace may be important for readability when the line with the closing brace is not a trivial one.
The configuration should allows not enforcing the rule in such cases.
E.g. a non-triggering-example would be:
if someCondition {
// do something
// do something
} else if ... {
// do something
// do something
// do something
} else {
// do something
// do something
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the VerticalWhitespaceClosingBracesRule implementation and inspect its existing configuration handling and rule tests. Add coverage for onlyEnforceBeforeTrivialLines using the issue's conditional-brace example, then verify that non-trivial closing-brace lines are exempt while trivial ones remain enforced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100