realm / realm/SwiftLint

Nested functions should be ignored for "Function body length"

Open
#3,762 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Swift
Stars
19.7k
Forks
2.3k
Avg merge
1d 1h
Merged PRs (30d)
11

Description

Basically reopening this: #385

I really think this should be implemented. Tools like Detekt for Kotlin also have this feature to ignore nested methods. Now I am forced to extract these Methods to class level which just makes it more visible to other class methods. This is not showing the correct intention of the developer "that this code should only be accessed from this method and I just grouped the logic via a nested method".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating SwiftLint’s Function Body Length rule and its existing tests, then review the earlier issue #385 for context on the intended nested-function behavior. Done means nested functions are excluded from the measured body length while ordinary function length checking remains unchanged, with tests covering both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.