Rule request: Avoid CGRect instance .size property (e.g. bounds.size or frame.size) and use .height and .width instead
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
New rule request
Please describe the rule idea, format
this issue's title as Rule Request: [Rule Name] and describe:
Use CGRect's .height and .width instead of accessing the same values via .size.height and size.width. This applies only to getting and not to setting.
- Why should this rule be added? Share links to existing discussion about what
the community thinks about this.
CGRect's height and width properties are equivalent to its size.height and size.width properties. Prefer using the shorthand notation.
- Provide several examples of what would and wouldn't trigger violations.
Given CGRect rect,
Would:
y = rect.size.height
x = rect.size.width
Wouldn't:
rect.size.height = y
rect.size.width = x
rect.height
rect.width
- Should the rule be configurable, if so what parameters should be configurable?
No
- Should the rule be opt-in or enabled by default? Why?
See README.md for guidelines on when to mark a rule as opt-in.
It should be opt-in as this is a code style preference,
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with README.md's opt-in rules guidance, then inspect existing SwiftLint rule implementations and their tests to find the relevant entry points. The rule should flag CGRect reads through size.height or size.width, while leaving assignments and direct height or width access unflagged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100