Rule Request: `implicit_return` should also enforce explicit returns
Open
Nobody has claimed this yet.
discussion
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
New rule request
implicit_return should also enforce explicit returns
Why should this rule be added?
When implicit_return is configured like:
implicit_return:
included:
- closure
- getter
I think it should also enforce explicit returns in contexts not included in the config (function in this example).
I always assumed it was a bug (and replied in #3029) until I read the source code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the source code for the implicit_return rule and the discussion in issue #3029 to understand how configured and unconfigured contexts are handled. Check the rule's existing tests, if present, and define done as making contexts excluded from the configuration enforce explicit returns without changing the configured behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100