Rule request: Forbid implicit return from closures
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
New rule request
Please describe the rule idea, format
this issue's title as Rule Request: [Rule Name] and describe:
-
Why should this rule be added? Share links to existing discussion about what
the community thinks about this.
Implicit returns from closure can be hard to read. -
Provide several examples of what would and wouldn't trigger violations.
Would
array.map { $0 }
Wouldn't
array.map { return $0 }
-
Should the rule be configurable, if so what parameters should be configurable?
No configuration required -
Should the rule be opt-in or enabled by default? Why?
See README.md for guidelines on when to mark a rule as opt-in.
Yes, the rule should be opt in or alternatively expressed as a configuration to the existing implicit return rule.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading README.md's opt-in-rules guidance and locating the existing implicit return rule referenced in the request. Compare the provided closure examples with that rule's behavior; done means the new opt-in rule identifies implicit closure returns while accepting explicit returns, without requiring configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100