Rule Request: Prevent moot protocol conformance
Open
Nobody has claimed this yet.
rule-request
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Updated SwiftLint to the latest version
- I searched for existing GitHub issues
New rule request
- Why should this rule be added? Share links to existing discussion about what the community thinks about this.
I sometimes see code use both Equatable and Hashable protocol conformance, but Hashable already inherits from Equatable, so the explicit Equatable conformance is moot.
- Provide several examples of what would and wouldn't trigger violations.
Would trigger:
struct Foo: Equatable, RawRepresentable, Hashable {}
Would not trigger:
struct Foo: RawRepresentable, Hashable {}
- Should the rule be configurable, if so what parameters should be configurable?
No
- Should the rule be opt-in or enabled by default? Why?
See README.md for guidelines on when to mark a rule as opt-in.
Enabled by default
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with README.md, especially the opt-in rules guidance, and review the requested triggering and non-triggering examples in this issue. Define the rule's behavior around explicit Equatable and Hashable conformances, then verify that the examples match the intended default-enabled rule.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100