realm / realm/SwiftLint

Rule Request: avoid if-not-else

Open
#2,031 0 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

rule-request
Dominant language
Swift
Stars
19.7k
Forks
2.3k
Avg merge
1d 1h
Merged PRs (30d)
11

Description

New Issue Checklist
Rule Request
  1. Proposal: when an if statement includes the else clause, the if clause should not be negated. The same applies to the ternary operator.

  2. Examples:

// Would trigger:
  if !test {
    methodA()
  } else {
    methodB()
  }

  if !(testA || testB) {
    methodA()
  } else {
    methodB()
  }

  !test ? methodA() : methodB()

// Would not trigger:
  if test {
    methodB()
  } else {
    methodA()
  }

  if testA || testB {
    methodB()
  } else {
    methodA()
  }

  if test ? methodB() : methodA()
  1. Should the rule be configurable, if so what parameters should be configurable?
    Not that I can think of.

  2. Should the rule be opt-in or enabled by default? Why?
    I, personally, would say yes, as if one is handling both possibilities, there is no need to do it with inverted logic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate SwiftLint's existing rule entry points and corresponding rule tests, then compare how conditional and ternary expressions are handled. Verify completion against the listed triggering and non-triggering examples, including negated if statements, negated compound conditions, and ternary expressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.