Rule request: No explicit `== true` or `== false`
Open
Nobody has claimed this yet.
rule-request
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
I occasionally come across code like this:
if condition == true { … }
which just be written as:
if condition { … }
I'd love to have a rule that disallowed == true and == false. (And != true, != false, which I haven't seen, but would be far worse.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating SwiftLint's existing rule implementations and tests for comparable equality or boolean-style checks. Add coverage for == true, == false, != true, and != false, with done defined as the new rule reporting those explicit comparisons without reporting the simplified boolean form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100