realm / realm/SwiftLint

Expand (or duplicate) closure end indentation rule for other cases

Open
#1,435 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

rule-request
Dominant language
Swift
Stars
19.7k
Forks
2.3k
Avg merge
1d 1h
Merged PRs (30d)
11

Description

Currently the closure_end_indentation rule is really awesome for cases like this:

foo
    .bar {
    } // this is enforced

I think it might be nice to spread this to other identifiers, such as this:

foo(
    bar
) // this should be enforced to be here

And also arrays:

let foo = [
    1, 2, 3,
] // this has to be here

etc.

Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing closure_end_indentation rule and compare its current behavior with the function-call and array examples in the issue. Define which additional closing identifiers are in scope and what indentation each should enforce, then add coverage demonstrating the agreed cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.