Rule request: XCTestCase should assert
Open
Nobody has claimed this yet.
rule-request
- Dominant language
- Swift
- Stars
- 19.7k
- Forks
- 2.3k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 11
Description
From: https://twitter.com/_petegoldsmith/status/849693584773263360
// good
func testOK() {
XCTAssertEqual(1 + 1, 2)
}
// bad
func testBad() {
someMethod()
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating SwiftLint's existing rule implementations and tests for a rule that inspects XCTestCase methods. Use the good and bad examples in the issue to define the expected detection behavior, then add coverage showing that test methods must contain an assertion. The issue does not name specific files or clarify edge cases, so these should be resolved before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100