readthedocs / readthedocs/ext-theme

Custom domains: Allow disabling "add" button instead of the whole listing

Open
#665 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
12
Forks
6
Avg merge
13h 25m
Merged PRs (30d)
1

Description

When isn't allowed to create a custom domain, the whole list is blocked, but we only want to block the "add" action, as users could have had domains already created, we still want users to be able to delete those.

ref https://github.com/readthedocs/ext-theme/pull/663

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the custom-domain listing and its add and delete actions in the ext-theme frontend. Verify the permission state described in the issue, then confirm that users who cannot create domains can still view and delete existing domains while the add action is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.