readthedocs / readthedocs/ext-theme
Don't render templates directly in forms
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 12
- Forks
- 6
- Avg merge
- 13h 25m
- Merged PRs (30d)
- 1
Description
builds/forms.py renders templates directly, which makes templating them here much harder or might not even work? Find out why this pattern was used, and likely undo it so that we can template those pieces instead of supplying the rendering template from Form code.
Here's a few:
-
projects/project_version_states_help_text.html -
projects/project_version_submit.html
both direct rendering in build/forms.py
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in builds/forms.py and inspect how it directly renders projects/project_version_states_help_text.html and projects/project_version_submit.html. Determine why the pattern was introduced, then verify that those template pieces can be templated without supplying their rendering templates from Form code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, python
- Domain
- backend, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100