readthedocs / readthedocs/ext-theme
404: where "Go back" link should go if the history is empty?
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 12
- Forks
- 6
- Avg merge
- 13h 25m
- Merged PRs (30d)
- 1
Description
When hitting a 404 page from the new dashboard, we show a "Go back" button that calls javascript:history.back(). However, it's pretty common to have nothing in the history, making that button to do nothing. We should probably check for this and link to the home or not even show that button.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the new dashboard's 404 page and inspect the "Go back" button that calls javascript:history.back(). Confirm the behavior when browser history is empty, then implement the chosen fallback to the home page or remove the button; done means the 404 action no longer does nothing in that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100