readthedocs / readthedocs/ext-theme

Add form element explaining why email login is disabled

Open
#330 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needed: design decision
Dominant language
HTML
Stars
12
Forks
6
Avg merge
13h 25m
Merged PRs (30d)
1

Description

I am pushing this issue off to later. I did give a try at showing a tooltip on a disabled menu item, but the combination of a menu, disabled item, and tooltip don't play together.

Normally, when using the disabled variant of many elements, this will disable all mouse events, including mouse events to child elements.

It is possible to do something like this however:

<div data-tooltip="This will show">
  <a class="ui disabled button">Even though this is disabled</a>
</div>

However, the nested structure of .ui.menu and .ui.menu.item are important and this workaround causes more edge cases. I also tried putting the tooltip on the .ui.menu which did technically work, but was a bit weird.

I think the disabled state is probably fine. If we get any confusion on this, it might be worth enabling the menu item and putting a form error on a disabled form. I could see how this would just be a confusing extra click too though.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is identified in the issue. Start by locating the email-login menu item and its disabled form, then review how .ui.menu, .ui.menu.item, and disabled form elements are rendered. Done means the interface explains why email login is disabled without introducing the tooltip and nested-menu edge cases described here.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.