readthedocs / readthedocs/ext-theme

Protect access to team form views using admin permission check

Open
#228 0 comments 0 reactions 1 assignee View on GitHub

@agjohnson is already working on this.

Since Sep 24, 2024.

Needed: design decision
Dominant language
HTML
Stars
12
Forks
6
Avg merge
13h 25m
Merged PRs (30d)
1

Description

I'm trying to tease apart the UX around organization teams and team members/projects, and found that the existing views are a bit overloaded. We don't quite have a read-only view of team detail or team member/project listing. I'm not even entirely sure if I want this, as this duplicates a lot of useful views.

The direction that I'm currently heading with the team, team member, and team project views is:

  • All of the form views for team, team members, and team projects would be placed under the organization admin dashboard. Only users with permissions to these views would be linked to them. This may not even involve adding any new views, but would instead be restructuring the templates so that the views appear not as a separate section from the admin dashboard.
  • Read only view of projects attached to a team is using a view filter for teams on the organization project listing. That is, a link on the team listing will link directly to the org project list with ?team__slug=foo query params.
  • Read only view of team members attached to a team is using a view filter for teams on the organization member listing view. That is, a link on the team listing will link directly to the org member list with ?team__slug=foo query params.

The other option is to duplicate the project and team member listing views under teams. This isn't wrong, but feels a bit confusing for sure. But this might only take one additional view, for a team project listing. Instead Organization Foo > Teams > Team Bar > Projects being a form view, it would be the project listing with a button at the top right to the project form view. This would keep everything as-is currently, and would help give a read-only and admin view in the same views/templates.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.