[0.85] feat(Pressable): add support for PlatformColor and alpha
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- react-native
- Domain
- mobile
Research direction
Start by reviewing the linked pull request #56395, since this issue identifies it as the commit or PR to be picked. Check how Pressable's android_ripple and TouchableNativeFeedback.Ripple handle colors, and consider the work done when PlatformColor and alpha are supported without the existing JavaScript invariant.
Written by the indexing model from the issue text.
Description
Target Branch
0.85
Link to commit or PR to be picked
https://github.com/facebook/react-native/pull/56395
Description
android_ripple on Pressable (and TouchableNativeFeedback.Ripple()) only
accepted numeric (pre-processed ARGB int) colors. Passing a PlatformColor
would throw an invariant in JS, making theme-aware ripple colors impossible.
This is useful for providing more flexibility when customizing ripple color.
- Dominant language
- No language data
- Stars
- 428
- Forks
- 11
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reactwg/react-native-releases
-
Type Pick Request
Difficulty 1/5 Under an hour Newbie friendliness 78/100
reactwg/react-native-releases#1349 · 1 comment · 1 reaction ·
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
reactwg/react-native-releases#1326 · 1 comment ·
-
Type Pick Request
Difficulty 1/5 Under an hour Newbie friendliness 35/100
reactwg/react-native-releases#1410 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
reactwg/react-native-releases#1403 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
reactwg/react-native-releases#1402 · 1 reaction ·
All issues in reactwg/react-native-releases
Similar issues
-
tvOS
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Good First Issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ankidroid/Anki-Android#21942 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
libre-tube/LibreTube#8781 · 1 comment ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
skiptools/skip-fuse-ui#147 ·