[0.84] Fix crash in tracking spring animations when toValue node is detached
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- android, react-native
- Domain
- mobile
Research direction
Start with commit 45de7109fe93db8052e9ba06e53807f89cbd7fd9 and trace the Android Native Animated spring path involved in detached toValue nodes. Review the regression test added there and run it. Done means teardown no longer propagates a null toValue into the spring configuration and the regression test passes.
Written by the indexing model from the issue text.
Description
Target Branch
0.84
Link to commit or PR to be picked
https://github.com/facebook/react-native/commit/45de7109fe93db8052e9ba06e53807f89cbd7fd9
Description
This fixes an Android Native Animated crash in a core animation path.
During teardown (unmount/re-render/navigation), a tracked toValue node can be detached and RN may pass toValue = null into spring config, causing NullPointerException.
This change prevents null propagation and adds a regression test. It is a single, low-risk fix with no reliable app-level workaround.
- Dominant language
- No language data
- Stars
- 428
- Forks
- 11
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from reactwg/react-native-releases
-
Type Pick Request
Difficulty 1/5 Under an hour Newbie friendliness 78/100
reactwg/react-native-releases#1349 · 1 comment · 1 reaction ·
-
Type Pick Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
reactwg/react-native-releases#1326 · 1 comment ·
-
Type Pick Request
Difficulty 1/5 Under an hour Newbie friendliness 35/100
reactwg/react-native-releases#1410 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
reactwg/react-native-releases#1403 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 20/100
reactwg/react-native-releases#1402 · 1 reaction ·
All issues in reactwg/react-native-releases
Similar issues
-
tvOS
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Good First Issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ankidroid/Anki-Android#21942 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
libre-tube/LibreTube#8781 · 1 comment ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
skiptools/skip-fuse-ui#147 ·