Improve default error reporting (debug mode via middleware for error event)

Open
#344 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
php
Domain
backend-api-design, networking

Research direction

Start with the proposal in issue #344 and the related documentation issue #342. No files, tests, or entry points are identified, and the behavior is still open to design decisions around debug output, proxy-aware IP limits, logging, and custom error handlers. Done cannot be defined until those choices are resolved.

Written by the indexing model from the issue text.

Description

help wanted maintenance question

I've just filed #342 to improve documentation for error handling for invalid requests and invalid responses respectively. This is only a first step because this keeps coming up and I think we agree it's about time to add some better default error handing logic.

This ticket aims to serve as a base to discuss how "default error handling logic" could look like.

For instance, we might want to just dump any Exception/Throwable including the full stack trace, but this may leak some application details to the outside. We may want to limit this to certain IP ranges only, but this won't work behind a reverse proxy anymore. We may want to add a "debug" flag or a DebugMiddleware, but this requires some explicit choice. We may want to respect PHP's error_reporting value, but it's unclear if this is how people understanding this configuration. We may want to log to STDERR instead of the response message, but it's unclear what effect this could have on existing deployments. We may want to apply our "default error handling logic" only if no explicit error is given, but it's unclear if this is what people expect when they start adding custom error handling logic.

Any input is welcome 👍

Dominant language
PHP
Stars
781
Forks
166
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactphp/http

All issues in reactphp/http

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.