reactphp / reactphp/http

Expose underlying connection in ServerRequest

Open
#324 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted new feature
Dominant language
PHP
Stars
781
Forks
166
PR merge metrics
No merged PRs in 30d

Description

The request object passed to the request handler should be able to access the underlying socket connection. At the moment, there is no way for the Connection object to be passed between a connection event handler and a request handler - an example of why this is an issue is data from a client certificate when using mutual authentication cannot be passed to the request handler (e.g. certificate Common Name).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how ServerRequest is created and how the connection event handler and request handler communicate. Determine where the underlying socket Connection can be exposed without breaking the request API; done means the request handler can access it and client-certificate data can be passed through for mutual authentication.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.