reactor / reactor/BlockHound

Provide non-shaded byte-buddy/asm distribution

Open
#436 3 comments 12 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

for/team-attention type/enhancement
Dominant language
Java
Stars
1.5k
Forks
95
Avg merge
1d 14m
Merged PRs (30d)
6

Description

Title: Enhancement Request: Provide Distribution Without Shading ByteBuddy and ASM

Description:

I would like to propose an enhancement for the Blockhound library regarding its dependency management, specifically concerning its use of shaded versions of ByteBuddy and ASM (aka provide additional artifact).

Current Situation:

Blockhound currently shades ByteBuddy and ASM within its distribution. While this approach can help avoid version conflicts, it also leads to several downsides:

  1. Version Locking: We often have to wait for a new release of Blockhound to access newer versions of ByteBuddy and ASM, even though these libraries are essential for various projects. Same for newer version of JDK releases.
  2. Code Duplication: Since ByteBuddy and ASM are commonly used across many other open-source projects, shading them results in unnecessary duplication of code within our classpath.
Suggested Enhancement:

I recommend that the Blockhound library be distributed without shading ByteBuddy and ASM in addition to shaded one with some qualifier.

Conclusion:

I believe that this enhancement would contribute to a smoother development experience for users of Blockhound, ultimately leading to a more robust and maintainable ecosystem.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified. Start by locating BlockHound's dependency and shading configuration, then determine how an additional non-shaded distribution would be published alongside the existing artifact; done means both distribution variants are available without disrupting the current shaded one.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.