[Typo]: "A stopwatch" example for useRef does not cleanup correctly
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
Summary
In "A stopwatch" example for useRef an interval is set in handleStart(). It is cleared in handleStop(). But if the component is unmounted after the interval is started, but without stopping it, it is never cleared, which means setNow can get called on an unmounted component.
Page
https://react.dev/reference/react/useRef#examples-value
Details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the useRef reference page at the linked example and inspect the “A stopwatch” code, starting with the interval created in handleStart() and stopped in handleStop(). Ensure the example also handles unmounting after start, then verify that the documented example no longer leaves the interval active when the component is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100