reactjs / reactjs/react.dev

[Bug]: Reusing Logic with Custom Hooks docs example doesn't work with firefox

Open
#7,088 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: unconfirmed
Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

Summary

On Firefox, for example with the code snippet that adds the event listener for 'online/offline' events. When the user goes offline, no event is triggered. In contrast to the Chromium browser, where everything works as expected. I'm curious why, given that both browsers support Navigator.onLine

Page

https://react.dev/learn/reusing-logic-with-custom-hooks

Details

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the linked “Reusing Logic with Custom Hooks” page and inspect the example that listens for online/offline events. Reproduce the reported behavior in Firefox and compare it with Chromium, then trace the example’s expected behavior and update the documentation once the discrepancy is understood. Done means the example behaves or is documented correctly in Firefox.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
documentation, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.