reactjs / reactjs/react.dev

[Documentation] Minor change in description of state-and-lifecycle.md

Open
#632 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

https://github.com/reactjs/reactjs.org/blob/master/content/docs/state-and-lifecycle.md#state-updates-are-merged

The merging is shallow, so this.setState({comments}) leaves this.state.posts intact, but completely replaces this.state.comments.

Type of merging doesn't matter in this case. Neither shallow, nor deep merge can overwrite this.state.posts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open content/docs/state-and-lifecycle.md at the “State Updates are Merged” section and review the quoted explanation of shallow merging. Update the description so it does not imply that either shallow or deep merging can overwrite this.state.posts; done means the wording accurately describes the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.