useEffect example could use something different like scrollY or scrollX.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
The useEffect example in the "Synchronizing with Effects" could use a different example, maybe like a window.scrollX or a window.scrollY instead of e.clientX and e.clientY as they don't exist on a scroll event and cause it to show undefined on scroll event.
useEffect(() => {
function handleScroll(e) {
console.log(e.clientX, e.clientY);
}
window.addEventListener('scroll', handleScroll);
return () => window.removeEventListener('scroll', handleScroll);
}, []);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the useEffect example in the “Synchronizing with Effects” documentation page and review how its scroll handler reads event properties. Update the example to use the scroll position described in the issue, then verify the rendered example no longer logs undefined values for a scroll event.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100