Challenge Solution in "Updating Arrays in State" Page Uses Mutation
Open
Nobody has claimed this yet.
feedback
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
For the solution to the third challenge in the Updating Arrays in State page, it uses the following function:
function handleAddTodo(title) {
setTodos([
...todos,
{
id: nextId++,
title: title,
done: false
}
]);
}
This changes nextId, a variable outside the component's scope, which I believe is a mutation. It should instead use the length of todos to set the next id.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the linked “Updating Arrays in State” page and inspect the third challenge’s solution, especially the handleAddTodo function and its nextId usage. Update the example so it does not mutate the variable outside the component, then verify that the challenge solution still produces the expected todo IDs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100