reactjs / reactjs/react.dev

Please include duration unit for actualDuration and baseDuration in React Profiler Doc Section

Open
#4,943 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

It would be better If onRender callback in Profiler section include time unit that is used for actualDuration and baseDuration arguments of onRender callback function to help the reader know the time unit.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the linked Profiler documentation and read the onRender callback section, focusing on the actualDuration and baseDuration arguments. Confirm the documented time unit and add it to that section; done means readers can determine the unit directly from the callback documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.