reactjs / reactjs/react.dev

Docs: not being accurate in one of faq examples

Open
#4,101 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

In a Passing Function to Components page in FAQ section. There is an example that claims that two functions are equivalent which is not so accurate.

<button onClick={() => this.handleClick(id)} />

<button onClick={this.handleClick.bind(this, id)} />
  • The first one only receives the id
  • the second will receive Synthetic click event as the second argument beside id

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the FAQ's Passing Function to Components page and inspect the example under “How do I pass a parameter to an event handler or callback?”. Update the explanation so it accurately describes the arguments received by each handler form, then verify that the example and surrounding text no longer claim the two functions are fully equivalent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.