[Beta] Ensure correct usage of :betterhover
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
It seems that when dark mode was added, some usage of :hover is missing betterhover class prefix
https://github.com/reactjs/reactjs.org/blob/beta/src/components/DocsFooter.tsx#L73
:betterhover is needed to only apply hover CSS on devices that support it (its secretly a media query under the hood). While not as good as react-aria/react-stately's hover detection hook (which understands if hybrid devices are in touch mode or not, the betterhover variant/screen is the next best CSS-only equivalent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/components/DocsFooter.tsx around line 73 and compare the hover usage with the dark-mode styling and the issue's betterhover requirement. Done means the affected hover CSS uses the betterhover prefix so it applies only on devices that support hover.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100