reactjs / reactjs/react.dev

Is it not clear if the effect's clean up logic from a component making using of context is ran BEFORE re-rendering any other instance of the same component (on the same hierarchy level)

Open
#3,879 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

Runnable example: https://codesandbox.io/s/fast-sunset-8c0z2?file=/src/App.js

What is clear: It is clear a change in context will cause all consumers to re-render.

What is not clear: When using useEffect's clean up function - ( return () => { do some clean up } ) will that always be done for ALL component instance using the same context BEFORE re-rendering the other components of the same type ( ie multiple instances of MyComp )?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the runnable CodeSandbox example linked in the issue and inspect src/App.js to reproduce the context update and useEffect cleanup behavior. Determine the ordering across multiple instances of MyComp, then document the answer and any relevant caveats in the appropriate React documentation location.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.