Document Why a "complex expression in the dependency array" Is a Problem
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.8k
- Forks
- 7.9k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 11
Description
this is about the exhaustive-deps eslint rule, specifically her: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L779. i've been trying to find out why having a complex expression inside of the dependency array is bad, but haven't found anything saying why something like [err?.message] would cause issues. is there somewhere it's listed in the docs that i haven't seen?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the exhaustive-deps rule implementation at packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js around line 779 and review the existing React documentation for dependency arrays. Document why complex expressions such as [err?.message] are problematic, with enough explanation for readers to understand the rule; done means the rationale is clearly covered in the appropriate docs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100