reactjs / reactjs/react-tabs

Add post-select hook

Open
#228 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.1k
Forks
455
Avg merge
5h 9m
Merged PRs (30d)
2

Description

Although react-tabs has onSelect, which is called when the tab is about to change, I see no post-update hook.

My requirements for this are that, I have to do some post-processing on the rendered DOM. On the parent component that I use react-tabs in, I do the post processing of parent component in its componentDidUpdate method but obviously the updates on the child (react-tabs in this case) doesn't trigger the post-update method of the parent.

It would be useful for me if there was a post-update hook on react-tabs.

Note: I can fix this by using the controlled-mode. Therefore feel free to close the issue if this looks like an unsuitable feature request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing onSelect callback with controlled-mode behavior and React's componentDidUpdate timing. Determine the intended post-update hook contract and how it should behave during tab changes. Done means the feature scope is agreed and its callback behavior is covered by tests and documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.