Any interest in a node renderer for reactjs/react-rails?

Open
#1,079 3 comments 18 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
18/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, node.js, rails, react
Domain
backend

Research direction

The issue names no files or tests. Start by reviewing the existing renderer and how react-rails uses ExecJS, then assess the scope of a Node.js renderer. The issue does not define acceptance criteria, so the implementation boundaries and tests would need to be agreed before work starts.

Written by the indexing model from the issue text.

Description

I've had a proper node renderer for quite some time for React on Rails Pro.

It's becoming increasingly useful to use NodeJS and not ExecJS for server-side rendering. Here are a few reasons:

  1. loadable-components and CSS in JS Emotion just work when using a proper node server and a build target of node (and not web). I suspect many other libraries are the same in this regard.
  2. Better for memory management
  3. Maybe better performance (and certainly if your Ruby process is running out of memory due to JS leaks)
  4. Options to debug using the Chrome dev tools.
  5. Ability to have SSR code read the file system, make asynch calls, and really anything a proper node program can do.

If there was sufficient interest, I could look into a port of the renderer that worked for react-rails.

Dominant language
JavaScript
Stars
6.8k
Forks
739
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from reactjs/react-rails

All issues in reactjs/react-rails

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.