reactiveui / reactiveui/Fusillade
Differing requests can be returned the same deduplicated response
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 314
- Forks
- 30
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 16
Description
It's possible that some differing requests receive the same response.
For example, making requests to the same endpoint, but with a different If-Modified-Since header, can result in the second request receiving the response from the first. These requests are perhaps being deduplicated when they should not be.
Our application makes use of the If-Modified-Since and If-None-Match headers. Looking at the UniqueKeyForRequest method, it appears that these headers are not taken into consideration. It also appears that non-idempotent requests such as POSTs may also be deduplicated, when a client may expect all of these requests to be send and responded to individually as state changes on the server.
Does this assessment seem on the right track, and would you accept a PR for these changes? Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the UniqueKeyForRequest method mentioned in the issue and trace how request keys are used for deduplication. Reproduce cases with differing If-Modified-Since and If-None-Match headers and with non-idempotent requests; the work is done when requests that should be handled individually no longer receive the same deduplicated response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100