react / react/yoga

Missing properties to get/set column/row gap in YogaProps

Open
#1,904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18.9k
Forks
1.6k
Avg merge
1m
Merged PRs (30d)
1

Description

Hello,

It looks like the YogaProps interface is missing the functions for setting the gap properties. The setGap and setGapPercentage are only available on the YogaNode

Like wise the getters are also missing. It looks like other properties also have getters exposed in the YogaProps

In our use case we rely on the YogaProps interface for setting the properties on the yoga nodes. With the missing gap functions, that is not possible and one needs to rely on YogaNode class it self in order to set the gap based properties. I'm not sure if that is by design, since all other properties are settable via the YogaProps interface, I'm guessing the missing gap related functions was just an oversight

Same thing is also present in the upcoming Grid support PR (#1898) which is missing the functions to set the grid specific properties in YogaProps, which makes me think if maybe we are miss understanding the usage of YogaProps?

Thanks in advance

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the YogaProps interface in java/com/facebook/yoga/YogaProps.kt and compare its existing property accessors with the gap methods on YogaNode.kt around line 209. Done means the interface exposes the needed column/row gap setters, percentage setters, and corresponding getters, consistently with the other properties.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.