Warning: remove non-ASCII comment to resolve C4819 encoding warning in VS2022 (zh-CN)
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18.9k
- Forks
- 1.6k
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss.
In line 30 of the file yoga\yoga\algorithm\SizingMode.h:
- A box’s “ideal” size in a given axis when given infinite available space.
It is recommended to change it to:
- A box's "ideal" size in a given axis when given infinite available space.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open yoga/yoga/algorithm/SizingMode.h and inspect the comment at line 30. Replace the non-ASCII quotation marks with ASCII characters as described, then build with VS2022 to confirm warning C4819 no longer appears.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100