react / react/yoga

Add a CMake option to not build the tests

Open
#1,624 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18.9k
Forks
1.6k
Avg merge
1m
Merged PRs (30d)
1

Description

I created a Conan package for yoga, but I have to patch out the line add_subdirectory(tests) in CMakeLists.txt because I do not want to build the tests when creating the package. A CMake option would be nice, something like option(BUILD_TESTS "Build tests" ON).

I am not allowed to contribute to yoga due to the Meta CLA, thus I closed the PR where I propose such a change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in CMakeLists.txt at add_subdirectory(tests) and review the existing CMake configuration. Add the requested option so package builds can skip the tests while the default continues to build them. Verify both option settings with a CMake configure or build.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.