Flex shorthand in UseWebDefaults should set basis to 0 instead of auto
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18.9k
- Forks
- 1.6k
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Since UseWebDefaults was added with https://github.com/facebook/yoga/commit/62f47190fb2c13d47b13efacfc237f30ab312b51, https://github.com/facebook/yoga/blob/62f47190fb2c13d47b13efacfc237f30ab312b51/yoga/Yoga.c#L493
https://www.w3.org/TR/css-flexbox-1/#flex-common says that zeroing is the right interpretation, so UseWebDefaults does the wrong thing seemingly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the historical Yoga.c location linked in the issue and trace the current UseWebDefaults handling for the flex shorthand. Compare its basis behavior with the W3C flexbox specification linked above, then verify that the implementation matches the specified zeroing behavior and add or update regression coverage if the repository provides it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, css
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100