react / react/yoga

Evaluate Profile-Guided Optimization (PGO) on Yoga

Open
#1,338 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C++ Enhancement
Dominant language
C++
Stars
18.9k
Forks
1.6k
Avg merge
1m
Merged PRs (30d)
1

Description

Report

According to the official website, one of the Yoga goals is performance. So I think would be a good idea to try to gain more performance by applying Profile-Guided Optimization (PGO) in Yoga.

Since Yoga is a library (not an executable), it could be a bit harder to do since for profile collection you need an executable. One of the things is to build the Yoga benchmark and Yoga library with PGO and measure the improvements.

If will be some performance improvements, would be helpful:

  • Write a note about PGO in Yoga documentation with performance improvement numbers.
  • Add an option to the build scripts for building Yoga library with PGO. In this case, for the users will be easier to rebuild Yoga for their own specific use cases

After that, I guess LLVM BOLT could be tested as well but I suggest trying BOLT only after PGO since PGO implementations in compilers are much more mature compared to BOLT (IMHO).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Yoga benchmark, Yoga build scripts, and documentation, then determine how an executable can collect PGO profiles for the library. Measure the benchmark with and without PGO and record the performance results. Done means deciding whether the improvement justifies documentation and a build option; LLVM BOLT is a later consideration.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.