react / react/react-native

build failing with react native@0.81.5

Open Beginner friendly
#58,448 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Author Feedback Needs: Repro
Dominant language
C++
Stars
127k
Forks
25.3k
Avg merge
1d 23h
Merged PRs (30d)
4

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native@0.81.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native/ReactCommon/react/renderer/core/graphicsConversions.h b/node_modules/react-native/ReactCommon/react/renderer/core/graphicsConversions.h
index bb59351..bcff1d7 100644
--- a/node_modules/react-native/ReactCommon/react/renderer/core/graphicsConversions.h
+++ b/node_modules/react-native/ReactCommon/react/renderer/core/graphicsConversions.h
@@ -76,8 +76,11 @@ inline folly::dynamic toDynamic(const YGValue& dimension) {
       return "stretch";
     case YGUnitPoint:
       return dimension.value;
-    case YGUnitPercent:
-      return std::format("{}%", dimension.value);
+    case YGUnitPercent: {
+      char buffer[32];
+      std::snprintf(buffer, sizeof(buffer), "%g%%", dimension.value);
+      return std::string(buffer);
+    }
   }
 
   return nullptr;

This issue body was partially generated by patch-package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ReactCommon/react/renderer/core/graphicsConversions.h and reproduce the React Native 0.81.5 build failure. Compare the percent-value conversion shown in the issue with the surrounding code, then verify that the project builds without a patch-package workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
build-system, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.